Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for binding provider #84

Closed
wants to merge 12 commits into from
Closed

feat: add support for binding provider #84

wants to merge 12 commits into from

Conversation

koladilip
Copy link
Collaborator

Description of the change

binding provider helps to resolve bindings using custom logic and using caller node_modules

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@koladilip koladilip requested a review from utsabc August 29, 2023 17:30
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 1488/1488
🟢 Branches 100% 301/301
🟢 Functions 100% 112/112
🟢 Lines 100% 1488/1488

Test suite run success

157 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 740a4e9

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cda8ad7) 100.00% compared to head (740a4e9) 100.00%.
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main       #84    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        46     +1     
  Lines         1372      1488   +116     
  Branches       249       266    +17     
==========================================
+ Hits          1372      1488   +116
Files Changed Coverage Δ
src/steps/base/executors/base.ts 100.00% <ø> (ø)
src/steps/base/executors/workflow_step.ts 100.00% <ø> (ø)
src/steps/composed/executors/composable.ts 100.00% <ø> (ø)
src/bindings/common.ts 100.00% <100.00%> (ø)
src/steps/composed/executors/loop.ts 100.00% <100.00%> (ø)
src/steps/composed/factory.ts 100.00% <100.00%> (ø)
src/steps/errors.ts 100.00% <100.00%> (ø)
src/steps/types.ts 100.00% <100.00%> (ø)
src/steps/utils.ts 100.00% <100.00%> (ø)
src/workflow/default_executor.ts 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip
Copy link
Collaborator Author

split into multiple PR

@koladilip koladilip closed this Aug 31, 2023
@koladilip koladilip deleted the feat.add-support-binding-provider branch November 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc Awaiting requested review from utsabc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koladilip